Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decouple config manager in true singleton #190

Merged
merged 6 commits into from
Feb 4, 2022

Conversation

dudantas
Copy link
Contributor

@dudantas dudantas commented Feb 2, 2022

ConfigManager class decoupled in a true singleton, thus allowing direct calls without needing to instantiate in each file.

Modification required for pull request: #32
This is optional, just to solve a sonar check issue.

Thanks @lgrossi for made the decouple logic.

@sonarcloud
Copy link

sonarcloud bot commented Feb 4, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 5 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit a53d747 into master Feb 4, 2022
@dudantas dudantas deleted the decouple-config-manager-in-true-singleton branch February 4, 2022 19:08
luan pushed a commit that referenced this pull request Jul 11, 2023
ConfigManager class decoupled in a true singleton, thus allowing direct calls without needing to instantiate in each file.

Modification required for pull request: #32
This is optional, just to solve a sonar check issue.

Credits to @lgrossi for made the decouple logic.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants