fix: adjust target reach assumption immediately after setting #1902
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a pretty subtle bug, but it prevents the
challenge
spell from working most of the time. This is what occurs:onThink
runs,hasFollowPath
is stillfalse
because we haven't had time to run the path finding algo yet; we think it's unreachable and switch away to the other target (with we already had a path for)Solution: by "assuming" we have a path, we let the pathfinding algo run, in the meantime
onThink
assumes everything is OK.