feat: custom npc shop items from lua table #1947
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andersonfaaria
approved these changes
Dec 1, 2023
luan
approved these changes
Dec 1, 2023
|
@dudantas maybe do https://github.com/opentibiabr/canary/blob/main/data-otservbr-global/npc/battlemart.lua also? since he sells so much stuff. |
majestyotbr
approved these changes
Dec 1, 2023
dudantas
force-pushed
the
dudantas/feat-npc-shop-based-on-keywords
branch
from
e5af2a5
to
6bf229e
Compare
dudantas
changed the title
dudantas
changed the title
Good idea, I'll do it, thanks for remembering. |
dudantas
force-pushed
the
dudantas/feat-npc-shop-based-on-keywords
branch
2 times, most recently
from
dd0f466
to
012f273
Compare
dudantas
force-pushed
the
dudantas/feat-npc-shop-based-on-keywords
branch
from
82381b9
to
8e297dc
Compare
|
Kudos, SonarCloud Quality Gate passed! |
|
gread .. goood |
elsongabriel
approved these changes
Dec 1, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces a new feature that allows for the creation of NPC shop items from lua dynamic tables. It is now possible to associate specific items with keywords/storage and others methods, and when a player interacts with an NPC shop, the items related to those methods will be displayed in the shop's inventory.
Key changes included in this pull request: