Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Few prey/task hunting fixes and improvements #385

Merged
merged 10 commits into from
Jun 11, 2022

Conversation

marcosvf132
Copy link
Contributor

@marcosvf132 marcosvf132 commented May 20, 2022

Description

  • Prrey/task hunting free reroll timer visual issue after the player very first login only.
    On player first login, there was a visual issue on the Prey/TaskHunting free reroll timer.
    image

  • Making prey bonus reroll more random.

  • VIsual issue on prey tracker window where the bonus was not being shown when there is no monster on the list.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • My changes generate no new warnings

Copy link

@Codemaufeito Codemaufeito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

testado e fixou o problema

@marcosvf132 marcosvf132 marked this pull request as draft May 31, 2022 19:39
- Change 'normal_random' to 'uniform_random', to make it full random.
- Change prey selection type when rerolling the slot, since the bonus is maintained.
@sonarcloud
Copy link

sonarcloud bot commented May 31, 2022

Please retry analysis of this Pull-Request directly on SonarCloud.

@marcosvf132 marcosvf132 changed the title [Fix] Prey free reroll timer issue on first login [Fix] Few prey/task hunting fixes and improvements May 31, 2022
@marcosvf132 marcosvf132 marked this pull request as ready for review May 31, 2022 21:47
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
13.6% 13.6% Duplication

@majestyotbr majestyotbr merged commit b1786d5 into opentibiabr:main Jun 11, 2022
@marcosvf132 marcosvf132 deleted the fix-prey-time branch June 14, 2022 13:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants