Rework on movements revscriptsys #398
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dudantas
force-pushed
the
rework-on-movements-revscriptsys
branch
from
6bab3b0
to
d090357
Compare
Fix crash related to replaceable, validating some nullpointer, remove usings and some indentations Changed from "!" to explicit "nullpointer" comparison Added MagicField validation
dudantas
force-pushed
the
rework-on-movements-revscriptsys
branch
2 times, most recently
from
17abc67
to
d0ed88c
Compare
Fix register items Some sonar fixes
dudantas
force-pushed
the
rework-on-movements-revscriptsys
branch
2 times, most recently
from
17a67cb
to
da0b453
Compare
dudantas
force-pushed
the
rework-on-movements-revscriptsys
branch
from
da0b453
to
b6ae291
Compare
|
Kudos, SonarCloud Quality Gate passed! |
majestyotbr
approved these changes
May 31, 2022
guispiller
approved these changes
Jun 1, 2022
luan
pushed a commit
that referenced
this pull request
Jul 11, 2023
Movements completely redone to remove a memory leak related to the registration of movements, in the luaMoveEventRegister function, where the memory was fread and then used. We also added some pointer sanity checks, preventing future crashes and fixing some known ones. Removed old XML load Passed some objects as a reference, to avoid nullpointer Added nullpointer checks in some places and the code was redone to work better Added some logs to help in case of errors Fixed crash related to replaceable magic fields Notes: MoveEvent::onRemoveItem function from now on it will no longer have the "tileitem" argument
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Movements completely redone to remove a memory leak related to the registration of movements, in the luaMoveEventRegister function, where the memory was fread and then used. We also added some pointer sanity checks, preventing future crashes and fixing some known ones.
Notes: MoveEvent::onRemoveItem function from now on it will no longer have the "tileitem" argument