Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed market offers duplication money and items #521

Merged
merged 20 commits into from
Oct 5, 2022

Conversation

dudantas
Copy link
Contributor

@dudantas dudantas commented Sep 17, 2022

Resolves #517
Resolves #520
Resolves #538

Global sync pr: https://github.com/opentibiabr/otservbr-global/pull/797/files

Changed max market offer price from uint32_t to uint64_t (from 999999999 to 999999999999 client limitation)

@guispiller
Copy link
Contributor

Duplicating money on market solved.

I found some other issues on the pr:

  • You can put items on market to sell for more than 4.999.999.999, but above that value, the value that the buyer pays and that the sellers receive is less than it should.
  • If you open a buy offer of price >250kkk, your money is removed but this distro error returns, and the offer is not created
    image
  • This also happens on sell offer, but only the fee price is deducted from your account and the offer is not created.

@dudantas dudantas changed the title Fixed market duplication money on cancel market offer Fixed market duplication money on market offers Oct 5, 2022
@dudantas
Copy link
Contributor Author

dudantas commented Oct 5, 2022

Duplicating money on market solved.

I found some other issues on the pr:

  • You can put items on market to sell for more than 4.999.999.999, but above that value, the value that the buyer pays and that the sellers receive is less than it should.
  • If you open a buy offer of price >250kkk, your money is removed but this distro error returns, and the offer is not created
    image
  • This also happens on sell offer, but only the fee price is deducted from your account and the offer is not created.

Can test again, please?

@dudantas dudantas changed the title Fixed market duplication money on market offers Fixed market offers duplication money and items Oct 5, 2022
@gerotib
Copy link
Contributor

gerotib commented Oct 5, 2022

I tested only last commit now, and #538 is fixed.

@dudantas
Copy link
Contributor Author

dudantas commented Oct 5, 2022

I tested only last commit now, and #538 is fixed.

Thanks for testing. I'll merge it soon.

@sonarcloud
Copy link

sonarcloud bot commented Oct 5, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 9dd8a10 into main Oct 5, 2022
@dudantas dudantas deleted the fix-market-duplication-money branch October 5, 2022 15:34
luan pushed a commit that referenced this pull request Jul 11, 2023
Resolves #517
Resolves #520
Resolves #538

Global sync pr: https://github.com/opentibiabr/otservbr-global/pull/797/files

Changed max market offer price from uint32_t to uint64_t (from 999999999 to 999999999999 client limitation)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: PRs Done
3 participants