Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement] change project to c++ 20 #662

Merged
merged 11 commits into from
Dec 8, 2022
Merged

[Enhancement] change project to c++ 20 #662

merged 11 commits into from
Dec 8, 2022

Conversation

dudantas
Copy link
Contributor

@dudantas dudantas commented Dec 4, 2022 •
edited
Loading

Description

Modified for the project to support the use of c++ 20

New requirements:

  • CMake version 3.22
  • GCC version 9
  • Visual Studio version 17.3
  • Added minimum version of Visual Studio and GCC (c++ 20 requirement)

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I checked the PR checks reports
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works

@murilo09 murilo09 changed the title Change project for use c++ 20 Change project to use c++ 20 Dec 8, 2022
@dudantas dudantas changed the title Change project to use c++ 20 [Enhancement] change project to c++ 20 Dec 8, 2022
@dudantas
Fix sonar
2e183b0 
Added a function to get the current time with std::chrono
Changed some locations to use new std codes
@dudantas
Merge branch 'main' into change-projeto-to-cpp-20
5252dd9
@dudantas
Change to use fmt::format and fmt::localtime instead of localtime
f7a73c9 
Credits: otland/forgottenserver#4249
@sonarcloud
Copy link

sonarcloud bot commented Dec 8, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell B 6 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@dudantas dudantas merged commit 68c5b98 into opentibiabr:main Dec 8, 2022
luan pushed a commit that referenced this pull request Jul 11, 2023
@dudantas
[Enhancement] change project to c++ 20 (#662)
6e8de46 
Modified for the project to support the use of c++ 20
New requirements:
• CMake version 3.22
• GCC version 9
• Visual Studio version 17.3
• Added minimum version of Visual Studio and GCC (c++ 20 requirement)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@murilo09 murilo09 murilo09 approved these changes

@beats-dh beats-dh beats-dh approved these changes

@omeranha omeranha omeranha approved these changes

Assignees
No one assigned
Labels
Area: Source
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dudantas @omeranha @beats-dh @murilo09