Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVX-5446 Making amendments to force mute feature to disable mute state #237

Merged
merged 11 commits into from
Jan 28, 2022

Conversation

superchilled
Copy link
Contributor

@superchilled superchilled commented Jan 13, 2022

Description

Updates the force mute feature, to set the force_mute_all method to have active set to true by default (in order to mute all future streams) and to add an additional method disable_force_mute, which sets active to false in order to disable the mute state of the session (so that future streams are not automatically muted).

Motivation and Context

It implements a feature in the SDK which has already been added to the API. The main elements of the feature were added in #233, but this PR makes amendments to the feature to bring it in line with the actual API (some aspects of the previous implementation were erroneous due to and inaccuracies in the documentation).

How Has This Been Tested?

Example Output or Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • All new and existing tests passed.

@superchilled superchilled self-assigned this Jan 13, 2022
@superchilled superchilled changed the title Making amendments to force mute feature to disable mute state DEVX-5446 Making amendments to force mute feature to disable mute state Jan 13, 2022
@superchilled superchilled merged commit 8788f90 into dev Jan 28, 2022
@superchilled superchilled deleted the devx-5446-force-mute-feature-amendments branch January 28, 2022 17:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants