Menu icons color issue in macOS light and dark modes

[artisteacher]

Describe the bug
Icons are too light for the native menu on macOS Mojave. I haven't had a chance to check out other versions of macOS yet.

Screenshots

Device Information:

• OS: [macOS Mojave]
• OpenToonz Version: [Nightly (2021-03-30)]

[konero]

I think this might be why I disabled them before, a number of things to consider:

• [USER] Switch to dark mode on macOS if these are important
• [USER] Switch to light theme in OT with dark icons
• [DEV] Disable these showing in menus for macOS only as quickfix (maybe a pref option)

I know it's not ideal, as for an actual solution I think maybe one way would be to separate the main menu and command bar so they create unique icons each if they don't already, create a way to detect macOS dark mode, then where the main menu is created and calls createQIcon() pass a QColor as an argument into the recolorPixmap() calls, and pick black or white depending if macOS has dark mode active.

That's above my skill level though! Not even sure if detecting macOS dark mode is possible or not. 😟

May also be worth reading how these guys handled the same problem: LMMS/lmms#3349, looks like they ended up disabling them on macOS.

[artisteacher]

You are right that this is a light/dark mode issue. The white menu icons are too light in light mode. The black icons aren't ideal in dark mode.

I don't have strong feelings about the icons being visible or not in the menu for macOS. They are a little busy, yet helpful.

I do feel strongly that the user shouldn't have to change the system theme to give the menu icons better contrast. Users also shouldn't have to experiment with theme/icon combinations to find one that displays properly for the light or dark mode.

[artisteacher]

Now that the icons are optional in the menu, this is no longer an issue.