From 67538cf5cbb27d44b3a6c3ec9eff6a4a4e2e627c Mon Sep 17 00:00:00 2001 From: Carlos Alberto Cortez Date: Wed, 21 Mar 2018 14:54:15 +0100 Subject: [PATCH] Deprecate the StringTag.set() overload taking a StringTag. It's not a common scenario to use a Tag *key* as the tag value. --- .../src/main/java/io/opentracing/tag/StringTag.java | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/opentracing-api/src/main/java/io/opentracing/tag/StringTag.java b/opentracing-api/src/main/java/io/opentracing/tag/StringTag.java index 06e13f5b..f3904dd7 100644 --- a/opentracing-api/src/main/java/io/opentracing/tag/StringTag.java +++ b/opentracing-api/src/main/java/io/opentracing/tag/StringTag.java @@ -25,6 +25,10 @@ public void set(Span span, String tagValue) { span.setTag(super.key, tagValue); } + /** + * @deprecated as using the tag *key* as tag value is not usually required. + */ + @Deprecated public void set(Span span, StringTag tag) { span.setTag(super.key, tag.key); }