fix: bad log #259
Merged
fix: bad log #259
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For the remove and view command users should not specify package versions. I.e. they should not use these commands like `openupm remove com.some.package@1.0.0`. If they do specify a version, then a message warning the user should be printed. This message is currently incorrect. If a user would use the command as above it would print `please do not specify a version (Write only 'com.some.package@1.0.0').`. This log also includes a version, despite that that is the exact issue. Fixed. Now the log will say `please do not specify a version (Write only 'com.some.package').`
github-actions bot
pushed a commit
that referenced
this pull request
Apr 20, 2024
## [1.22.2](1.22.1...1.22.2) (2024-04-20) ### Bug Fixes * bad log ([#259](#259)) ([ac23e7b](ac23e7b))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For the remove and view command users should not specify package versions. I.e. they should not use these commands like
openupm remove com.some.package@1.0.0. If they do specify a version, then a message warning the user should be printed.This message is currently incorrect. If a user would use the command as above it would print
please do not specify a version (Write only 'com.some.package@1.0.0').. This log also includes a version, despite that that is the exact issue.Fixed. Now the log will say
please do not specify a version (Write only 'com.some.package').