feat: deduplicate log #275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a package the app will warn if the version inside ProjectVersion.txt is malformed. If multiple packages are added it will make this warning for each package. This seems a bit redundant. Probably we should only log the warning once at the beginning of the add operation.
|
@favoyang Thoughts? |
favoyang
approved these changes
Apr 21, 2024
|
I'm okay with the change, but it's just a tiny improvement for me. |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 22, 2024
# [1.23.0](1.22.2...1.23.0) (2024-04-22) ### Features * deduplicate log ([#275](#275)) ([31e7f42](31e7f42))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When adding a package the app will warn if the version inside ProjectVersion.txt is malformed. If multiple packages are added it will make this warning for each package.
This seems a bit redundant. Probably we should only log the warning once at the beginning of the add operation.