refactor: remove cwd pre-check #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, we check if cwd exists during `parseEnv`. This is not really necessary, because all operations which use cwd will also check if the path exist or handle missing files accordingly. We can thus safely remove this check. This comes with two slight changes in behavior: - The app fails later if cwd is not found. Instead of the app failing immediately during start-up, will will only fail once cwd is actually required. - There was a error-log in `parseEnv` which notified of the missing path. This log is now removed.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
## [1.23.1](1.23.0...1.23.1) (2024-04-24) ### Bug Fixes * remove cwd pre-check ([#276](#276)) ([52f988d](52f988d))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, we check if cwd exists during
parseEnv. This is not really necessary, because all operations which use cwd will also check if the path exist or handle missing files accordingly.We can thus safely remove this check. This comes with two slight changes in behavior:
parseEnvwhich notified of the missing path. This log is now removed.