fix: incorrect log #287
Merged
fix: incorrect log #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The error log for when a package version could not be found is currently incorrect. When adding package `com.some.package@2.0.0` and the primary registry has the package, just not that version the app will still fail with "not found". This is because `com.some.package` does not exist at all in the upstream registry and that error overrides the first "version not found". Fixed by checking which error is more fixable and printing that. A missing version is more fixable than the package not existing at all.
github-actions bot
pushed a commit
that referenced
this pull request
Apr 24, 2024
## [1.23.2](1.23.1...1.23.2) (2024-04-24) ### Bug Fixes * incorrect log ([#287](#287)) ([320fb36](320fb36))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The error log for when a package version could not be found is currently incorrect.
When adding package
com.some.package@2.0.0and the primary registry has the package, just not that version the app will still fail with "not found". This is becausecom.some.packagedoes not exist at all in the upstream registry and that error overrides the first "version not found".Fixed by checking which error is more fixable and printing that. A missing version is more fixable than the package not existing at all.