feat: extract remove service #352
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change extracts all business logic out of the remove command into its own service function. The cmd function is now only responsible for cli related logic. This change also slightly changes the behavior of the remove command. - Logs are rewritten - Information about removed packages is printed all at once at the end when the atomic remove process is complete. Previously messages about removed packages were printed as soon as the in-memory manifest was modified. The command could still fail however and then these logs would be confusing.
github-actions bot
pushed a commit
that referenced
this pull request
May 30, 2024
# [2.3.0](2.2.0...2.3.0) (2024-05-30) ### Features * extract remove service ([#352](#352)) ([61ebed9](61ebed9))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change extracts all business logic out of the remove command into its own service function. The cmd function is now only responsible for cli related logic.
This change also slightly changes the behavior of the remove command.