feat: drop namespace logic #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was only used in namespace logic and is no longer required
github-actions bot
pushed a commit
that referenced
this pull request
Dec 20, 2023
# [1.18.0](1.17.0...1.18.0) (2023-12-20) ### Features * drop namespace logic ([#67](#67)) ([4a6eef2](4a6eef2))
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the namespace logic from the app. This is a potentially breaking change.
Effects
The domain name of the package registry (usually
com.openupm) will not be added to manifests' scopes anymore when adding a package.Reason
This was discussed with @favoyang in a private chat. In short: The namespace logic was included in order to allow for finding Openupm packages from inside the Unity editor using a tool that would have been developed in the future. Such tools, which distribute packages from inside the editor, are not allowed by Unity and so this plan was abandoned. Thus the namespace logic is not currently used.