fix: trailing slash issue when finding auth in upmconfig #94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Registry urls now never have a trailing slash. This has the effect that they will also always be saved to upmconfig without trailing slash.
Search npm-auth for registry using both the regular registry url as well as with a trailing slash.
ComradeVanti
changed the title
favoyang
requested changes
Jan 1, 2024
favoyang
approved these changes
Jan 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #29
This PR ensures that all registry-urls inside the app-domain have no trailing slash. They are also saved like this to the
.upmconfig.toml.When querying for a registry-auth from the
upmconfig, the program will now search for the registry-url both with and without the trailing slash to find it more reliably.Added tests to ensure this behavior.