From c6db1a091385308f2b8c7a3f791922ebbfdca4c3 Mon Sep 17 00:00:00 2001
From: Ramon Brullo <kingvanti650@gmail.com>
Date: Sat, 13 Jan 2024 11:23:15 +0100
Subject: [PATCH] refactor: extract helper function

Extract helper function for converting a dependency error to a log-prefix. This simplifies the code inside the actual `deps` function.
---
 src/cmd-deps.ts | 14 +++++++++-----
 1 file changed, 9 insertions(+), 5 deletions(-)

diff --git a/src/cmd-deps.ts b/src/cmd-deps.ts
index 1d67877b..83cc3f57 100644
--- a/src/cmd-deps.ts
+++ b/src/cmd-deps.ts
@@ -1,6 +1,6 @@
 import log from "./logger";
 import { parseEnv } from "./utils/env";
-import { fetchPackageDependencies } from "./registry-client";
+import { Dependency, fetchPackageDependencies } from "./registry-client";
 import { isPackageUrl } from "./types/package-url";
 import {
   packageReference,
@@ -15,6 +15,12 @@ export type DepsOptions = CmdOptions<{
   deep?: boolean;
 }>;
 
+function errorPrefixForError(errorReason: Dependency["reason"]): string {
+  if (errorReason === "package404") return "missing dependency";
+  else if (errorReason === "version404") return "missing dependency version";
+  return "unknown";
+}
+
 /**
  * @throws Error An unhandled error occurred
  */
@@ -46,10 +52,8 @@ export const deps = async function (
   depsInvalid
     .filter((x) => !x.self)
     .forEach((x) => {
-      let reason = "unknown";
-      if (x.reason == "package404") reason = "missing dependency";
-      else if (x.reason == "version404") reason = "missing dependency version";
-      log.warn(reason, packageReference(x.name, x.version));
+      const prefix = errorPrefixForError(x.reason);
+      log.warn(prefix, packageReference(x.name, x.version));
     });
 
   return 0;