Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Is this repo redundant/outdated? #2

Open
easherma opened this issue Jun 16, 2016 · 2 comments
Open

Is this repo redundant/outdated? #2

easherma opened this issue Jun 16, 2016 · 2 comments

Comments

@easherma
Copy link

Does the libpostal library effectively replace the function of this python app (assuming some sort of basic wrapper, Flask or otherwise)?

https://github.com/openvenues/libpostal/blob/parser-data/scripts/geodata/names/deduping.py

@albarrentine
Copy link
Contributor

Outdated, yes, but not entirely redundant. This app uses libpostal's Python-only, English-only predecessor, address_normalizer, which is deprecated and has been replaced by libpostal/pypostal. Swapping it out for pypostal would take a tiny amount of refactoring but not much.

There's been some discussion around re-architecting this for use in the Pelias import process. The Pelias team mostly uses NodeJS, and since libpostal has Node bindings, it might make more sense on their side to rewrite this in Node and embed calls to libpostal directly rather than making batches of calls over HTTP.

The class mentioned in libpostal's geodata package is used for deduping place names across data sets (Quattroshapes/WOE names vs. OSM) rather than addresses.

@easherma
Copy link
Author

Julian and I chatted about this and I pointed him towards that node library for libpostal. However, for my current use case I'm working on a data-pipeline for bulk geocoding locally and that will be written in python (using luigi), so I might be interested in a refactor of this to use pypostal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants