Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Good First Issue]: Support aten::quantile #28395

Open
mvafin opened this issue Jan 12, 2025 · 6 comments · May be fixed by #28599
Open

[Good First Issue]: Support aten::quantile #28395

mvafin opened this issue Jan 12, 2025 · 6 comments · May be fixed by #28599
Assignees
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale

Comments

@mvafin
Copy link
Contributor

mvafin commented Jan 12, 2025

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

TBD

@mvafin mvafin added good first issue Good for newcomers category: PyTorch FE OpenVINO PyTorch Frontend no_stale Do not mark as stale labels Jan 12, 2025
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Jan 12, 2025
@gatbontonp
Copy link

.take

Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Jan 13, 2025
@pawarmanasi07
Copy link

Hi @gatbontonp! I noticed you're working on this issue. Would you be open to collaboration? I'd be happy to help with implementation or testing. If you've already started, I could focus on specific parts of the task, like writing tests or documentation.

@geeky33
Copy link
Contributor

geeky33 commented Jan 22, 2025

hello @mvafin can you please look upto the PR made
@andrei-kochin I took the permission for creating the PR.

@gatbontonp
Copy link

Hi @geeky33, I think you're missing the other interpolation methods and q can be a float or a tensor. I'm pretty close to finishing up and submitting a PR. Not sure if we want to wait for mine and just use @geeky33 's

@geeky33
Copy link
Contributor

geeky33 commented Jan 22, 2025

Hi @gatbontonp thank you for your feedback and for pointing out the additional considerations! I really appreciate the work you've done so far, and I didn't mean to overlap or rush things—I just got excited about the issue and wanted to contribute.

I’ve already put in significant effort into my PR, and it’s ready for review. I believe it addresses the issue comprehensively, including the interpolation methods and handling cases where q is a float or tensor. I’d love for you to take a look and share your thoughts on it. If there are any improvements or adjustments needed, I’m happy to incorporate them.

Since my PR is already complete, I think it would be efficient to move forward with it to avoid duplication of effort. However, if there are specific aspects of your work that you feel should be included, I’m open to collaborating and integrating them into my PR.
Although before making any such PR, I have always ensured to ask the maintainers of the repository for the permissions and once I get the approval from them, hence I did it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Status: Assigned
Development

Successfully merging a pull request may close this issue.

4 participants