Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Good First Issue]: Support aten::bincount #28526

Open
mvafin opened this issue Jan 17, 2025 · 6 comments · May be fixed by #28594
Open

[Good First Issue]: Support aten::bincount #28526

mvafin opened this issue Jan 17, 2025 · 6 comments · May be fixed by #28594
Assignees
@rk119
Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale

Comments

@mvafin
Copy link
Contributor

mvafin commented Jan 17, 2025

Context

OpenVINO component responsible for support of PyTorch models is called as PyTorch Frontend (PT FE). PT FE converts a model represented as TorchScript model to a model in OpenVINO opset.

What needs to be done?

  • Implement conversion rule and/or transformation to support the new operation.
  • Implement operation tests in tests/layer_tests/pytorch_tests. Please consider different data types, but keep reasonable number of test cases

Example Pull Requests

#18998

Resources

Contact points

@openvinotoolkit/openvino-pytorch-frontend-maintainers

Ticket

TBD
@mvafin mvafin added category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale labels Jan 17, 2025
@github-project-automation github-project-automation bot moved this to Contributors Needed in Good first issues Jan 17, 2025
@rk119
Copy link

rk119 commented Jan 17, 2025

.take

@github-actions GitHub Actions
Copy link
Contributor

Thank you for looking into this issue! Please let us know if you have any questions or require any help.

@mlukasze mlukasze moved this from Contributors Needed to Assigned in Good first issues Jan 20, 2025
@darksapien23151
Copy link
Contributor

@mvafin I've submitted a PR for the same and am requesting you to look into it

@rk119
Copy link

rk119 commented Jan 21, 2025 •
edited
Loading

Hi @darksapien23151,

While I appreciate your efforts, I was already working on this issue..as I have assigned it to myself a few days ago by taking it.

cc: @mvafin

@darksapien23151
Copy link
Contributor

Hey @rk119 ,

Got it, thanks for pointing that out! Since the issue was stale for a few days, I went ahead and worked on it, and I’ve already submitted a PR. Happy to know if you’d like to review or discuss how we can combine efforts to close this effectively.

Cheers!
cc: @mvafin

@rk119
Copy link

rk119 commented Jan 22, 2025

@darksapien23151, its alright :)

@rkazants rkazants linked a pull request Jan 22, 2025 that will close this issue
support for aten::bincount #28594
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rk119 rk119

Labels
category: PyTorch FE OpenVINO PyTorch Frontend good first issue Good for newcomers no_stale Do not mark as stale
Projects
Good first issues
Status: Assigned
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

support for aten::bincount darksapien23151/openvino
3 participants
@mvafin @rk119 @darksapien23151