Support INFERENCE_NUM_THREADS options in LLAMA_CPP #898
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Ilya Lavrenov <ilya.lavrenov@intel.com>
ilya-lavrenov
approved these changes
Apr 17, 2024
| num_threads = it->second.as<int>(); | ||
| if (num_threads < 0) { | ||
| OPENVINO_THROW("INFERENCE_NUM_THREADS cannot be negative"); | ||
| } |
There was a problem hiding this comment.
OPENVINO_ASSERT(num_threads > 0, "INFERENCE_NUM_THREADS should be positive")
| if (ov::inference_num_threads == map_entry.first) { | ||
| int num_threads = map_entry.second.as<int>(); | ||
| if (num_threads < 0) { | ||
| OPENVINO_THROW("INFERENCE_NUM_THREADS cannot be negative"); |
There was a problem hiding this comment.
let's use OPENVINO_ASSERT
| @@ -0,0 +1,8 @@ | |||
| project(llama_cpp_test_common) | |||
There was a problem hiding this comment.
please, add copyright
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both plugin and model settings should be working now. Removed the
openvino::funcSharedTestsfrom the test build since the majority of the shared tests are irrelevant or incompatible with theLLAMA_CPPplugin flow right now.