Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cherry Pick PR 3095 To The 0.11.x and 0.12.x branches #3119

Closed
swcurran opened this issue Jul 23, 2024 · 9 comments
Closed

Cherry Pick PR 3095 To The 0.11.x and 0.12.x branches #3119

swcurran opened this issue Jul 23, 2024 · 9 comments
Assignees

Comments

@swcurran
Copy link
Contributor

Please take the changes in PR 3095 and apply them to 0.11.x and 0.12.x branches so that we can release them.

@dbluhm
Copy link
Contributor

dbluhm commented Jul 23, 2024

I have a couple of other changes that I have parties interested in getting in a 0.12.x release:

Any chance we could cherry-pick these over as well? I think they're self-contained enough that I would be worried about issues but I understand if this isn't feasible

@dbluhm
Copy link
Contributor

dbluhm commented Jul 23, 2024

Happy to do some leg-work to make it happen, too

@swcurran
Copy link
Contributor Author

Happy to see those in the release — go for it. Hopefully the tests cover these. I’m not good enough at git to do the cherry picking :-).

@jamshale
Copy link
Contributor

I'll give it a shot and see how many issues I encounter.

@jamshale
Copy link
Contributor

I remember now. I looked at this before. I think 0.11.x is straightforward but I'm not sure about 0.12.x? There's no branch for this. Should we create one first? Or am I going to be using tags instead?

@swcurran
Copy link
Contributor Author

Please create a branch for 0.12.0 at the 0.12.1 tag.

BTW — @dbluhm — are any of those PRs you listed security patches such that they should be 0.11.x as well, or are they just nice to haves for 0.12.x?

Thanks!

@dbluhm
Copy link
Contributor

dbluhm commented Jul 23, 2024

Nice to haves; bug fixes, interop, and extensibility

@dbluhm
Copy link
Contributor

dbluhm commented Jul 24, 2024

Oh, thought of one more (sorry): #3050
I suspect this is the change needed to unblock bcgov/traction#990

@loneil
Copy link
Contributor

loneil commented Jul 25, 2024

Thanks for including that one @dbluhm ! I tested out the 0.12.2 RC in a Traction deployment and it indeed now successfully completes OOB connections from Traction to the version of Credo in the BC Wallet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants