Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ Upgrade test and lint dependencies #2939

Merged
merged 15 commits into from
May 17, 2024

Conversation

ff137
Copy link
Contributor

@ff137 ff137 commented May 9, 2024

⬆️ Upgrades:

  • pytest: 8.0.0 -> 8.2.0
  • pytest-asyncio: 0.23.5 -> 0.23.6
  • pytest-cov: 4.1.0 -> 5.0.0
  • pytest-ruff: 0.1.1 -> 0.3.2

➖ Removes:

  • mock
    • This dependency is used to provide unittest.mock features to older version of python
    • Not needed with current python version

Edit: additional dependency upgrades from #2940 are pulled in here to speed up merge cycle

Therefore includes:
⬆️ Upgrades:

  • black: 24.3.0 -> 24.4.2
  • ruff: 0.1.2 -> 0.4.4
  • pre-commit: 3.3.3 -> 3.7.1

@ff137 ff137 changed the title ⬆️ Update test dependencies ⬆️ Upgrade test dependencies May 9, 2024
dbluhm
dbluhm previously approved these changes May 14, 2024
Copy link
Contributor

@dbluhm dbluhm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dbluhm
Copy link
Contributor

dbluhm commented May 14, 2024

Just need a lock file regen but I think these updates are good

@dbluhm dbluhm added the 1.0.0 To be addressed for the ACA-Py 1.0.0 release label May 14, 2024
@ff137 ff137 force-pushed the update/test-dependencies branch from b182b9e to d29dc11 Compare May 15, 2024 19:07
@ff137 ff137 changed the title ⬆️ Upgrade test dependencies ⬆️ Upgrade test and lint dependencies May 15, 2024
@ff137 ff137 force-pushed the update/test-dependencies branch from d29dc11 to fed9316 Compare May 15, 2024 19:12
@ff137
Copy link
Contributor Author

ff137 commented May 15, 2024

Not sure why Snyk Container is failing. @WadeBarnes I notice #2951 was recently merged to fix it, but for some reason that PR didn't have the Snyk Container job run as part of its checks

@WadeBarnes
Copy link
Contributor

Not sure why Snyk Container is failing. @WadeBarnes I notice #2951 was recently merged to fix it, but for some reason that PR didn't have the Snyk Container job run as part of its checks

Running into the annoying PRs don't have access to secrets and things needing account tokens to work issues again. Was afraid that was going to happen. I'll configure the Synk Container job to continue on error until we get it sorted.

@WadeBarnes
Copy link
Contributor

Not sure why Snyk Container is failing. @WadeBarnes I notice #2951 was recently merged to fix it, but for some reason that PR didn't have the Snyk Container job run as part of its checks

Running into the annoying PRs don't have access to secrets and things needing account tokens to work issues again. Was afraid that was going to happen. I'll configure the Synk Container job to continue on error until we get it sorted.

Decided to switch the job back to running on push for now. That way it's running until we can sort things for PRs.

@ff137
Copy link
Contributor Author

ff137 commented May 15, 2024

@WadeBarnes aah that can be tricky... Thanks! Will rebase once that's in

@ff137 ff137 marked this pull request as draft May 15, 2024 20:46
@WadeBarnes
Copy link
Contributor

@WadeBarnes aah that can be tricky... Thanks! Will rebase once that's in

The update to the Snyk Container job has been merged.

@ff137 ff137 marked this pull request as ready for review May 16, 2024 14:13
@ff137 ff137 force-pushed the update/test-dependencies branch from fed9316 to 1dfe856 Compare May 16, 2024 14:15
ff137 added 12 commits May 17, 2024 08:37
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
ff137 added 3 commits May 17, 2024 08:37
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
Signed-off-by: ff137 <ff137@proton.me>
@ff137 ff137 force-pushed the update/test-dependencies branch from 1dfe856 to 2b6c229 Compare May 17, 2024 06:37
Copy link

sonarcloud bot commented May 17, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@dbluhm dbluhm merged commit 4b2625d into openwallet-foundation:main May 17, 2024
8 checks passed
@ff137 ff137 deleted the update/test-dependencies branch May 17, 2024 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1.0.0 To be addressed for the ACA-Py 1.0.0 release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants