Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add OpenSSF Scorecard GHA - weekly #2955

Merged
merged 3 commits into from
May 16, 2024
Merged

Add OpenSSF Scorecard GHA - weekly #2955

merged 3 commits into from
May 16, 2024

Conversation

swcurran
Copy link
Contributor

Copies the Fabric version of this GHA, with the only changes being removal of the Fabric copyright comment and the change of the day of the week the job runs.

Might be nice to run immediately and see where we are.

Once we have the scorecard, we can investigate what other updates we want to do to improve the score.

Signed-off-by: Stephen Curran <swcurran@gmail.com>
Copy link
Contributor

@WadeBarnes WadeBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'd like to see the actions updated to use the version tags rather than the commit hashes. It will be easier for Dependabot to monitor for updates.

Otherwise LGTM

@swcurran
Copy link
Contributor Author

Checked the OpenSSF Repo and they are doing that as well — https://github.com/ossf/scorecard/blob/main/.github/workflows/scorecard-analysis.yml

I’d say we leave it as this for now.

What would we change it to if we did change it?

@WadeBarnes
Copy link
Contributor

Checked the OpenSSF Repo and they are doing that as well — https://github.com/ossf/scorecard/blob/main/.github/workflows/scorecard-analysis.yml

I’d say we leave it as this for now.

What would we change it to if we did change it?

Example:

uses: actions/checkout@b4ffde65f46336ab88eb53be808477a3936bae11 # v4.1.1

=>

uses: actions/checkout@v4

Signed-off-by: Stephen Curran <swcurran@gmail.com>
@swcurran
Copy link
Contributor Author

Updated 3 out of 4. Didn’t know what to do with the other one…suggestions?

.github/workflows/scorecard.yml Outdated Show resolved Hide resolved
.github/workflows/scorecard.yml Outdated Show resolved Hide resolved
.github/workflows/scorecard.yml Outdated Show resolved Hide resolved
.github/workflows/scorecard.yml Outdated Show resolved Hide resolved
@WadeBarnes
Copy link
Contributor

The versions need to be specified as valid tags.

Signed-off-by: Stephen Curran <swcurran@gmail.com>
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@swcurran
Copy link
Contributor Author

Changes made -- should be good now. I hope.

Back to you @WadeBarnes !

@WadeBarnes WadeBarnes merged commit cabd231 into openwallet-foundation:main May 16, 2024
8 checks passed
@swcurran swcurran deleted the openssf-scorecard branch May 17, 2024 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants