-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[rest] Add create-offer endpoint for credentials #156
Comments
For the 3rd item in the checklist, would that be a test for the createOffer and createInvitation endpoints, or the methods (functions)? |
The endpoints. The methods have been tested as part of AFJ, so this test is mostly to assure the encoding between json and data classes works correctly when calling these endpoints |
Got it |
Also if I use the createInvitation method for the create-offer endpoint, there would be no need for the create-legacy-connectionless-invitation test, correct? |
See my comment on the PR. We don't want to call create invitation from the create offer endpoint. This is two separate steps |
Should work with the oob create invitation and oob create legacy invitation endpoints
The current API doesn't provide a create-offer endpoint. The create-offer allows to send a credential without first creating a connection. The flow for creating a credential offer is as follows:
/credentials/create-offer
. The API for this should exactly match thesend-offer
API endpoint, EXCEPT for the connectionId, this can be left out. This method should intenrally callcreate-offer
and return the message + record./oob/create-invitation
and provide the returned message in themessages
array.2.b (alternative) Call
/oob/create-legacy-connectionless-invitation
and provide the recordId + message + domainThis invitation / invitation url can then be used by agent to receive a credential without first creating a connection.
Endpoint:
Input: input from send-offer without connectionId
Output:
You can get the json of the message / record by calling toJSON() on them.
Checlist:
The text was updated successfully, but these errors were encountered: