Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(anoncreds): issue revocable credentials #1427
feat(anoncreds): issue revocable credentials #1427
Changes from 18 commits
c228f88
cafe703
1bb11d8
b70ba0a
ea88904
1cba24c
7cb3f5f
12c7602
429da81
e635a49
9aeb57d
e155c8d
0cc2cb7
f5fba00
8fc9380
a8d824d
9c41913
970a17a
ea2e8ef
70e7651
7486550
998ead9
0527a0b
599d9d0
acf8c71
87d88c8
d5c7b6d
8bf88f3
64f6bfd
d4685cf
505bf08
64ce973
89aca1f
3ebb665
98e5380
da6aa63
2c1a3b3
8f5d6bf
e2f4964
c4c5648
347de98
430439e
89d60cd
61ac750
0096052
0b78645
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we provide the actual tailsFile? Or will that be impactful on performance?
We would like to upload the tails file somewhere. Do we need to load it from the tailsLocation and then upload it?
I thiught the tailsLocation contained the http url, not the path
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This
tailsLocation
thing is a bit confusing, as the output from the library is a RevocationRegistryDefinition whose tailsLocation is actually the local file path, and then we should update it with the actual URL path before storing in the wallet and publishing to the VDR.Besides this explanation, I think you are right and it will be better to not use the revocation registry definition object but its ID and either the local tails file path or the file contents itself. At first sight I'd prefer to pass the path, as usually libraries like fetch or axios do work well with file streams and that could be more efficient if handled by lower level modules.