Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature] Centralize Background API Task Notification Logic #265

Open
Aryamanz29 opened this issue Jul 27, 2023 · 1 comment
Open

[feature] Centralize Background API Task Notification Logic #265

Aryamanz29 opened this issue Jul 27, 2023 · 1 comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest

Comments

@Aryamanz29
Copy link
Member

We recently introduced new notification types for background API tasks of the ZeroTier VPN backend in openwisp-controller. As part of this implementation, we also created a Celery task class (OpenwispApiTask) that contains the notification logic, along with a retry mechanism. To enhance reusability, we propose centralizing this logic and the new notification types so that other OpenWISP modules can utilize them for background API call Celery tasks.

More Information:
@Aryamanz29 Aryamanz29 added the enhancement New feature or request label Jul 27, 2023
@nemesifier
Copy link
Member

We could replace the zerotier notification with the new generic message.
What do you think @pandafy?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest
Projects
OpenWISP Contributor's Board
Status: To do (general)
OpenWISP Priorities for next releases
Status: To do
Milestone
No milestone
Development

No branches or pull requests
2 participants
@nemesifier @Aryamanz29