Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Error Modal to read properties from GeppettoConfiguration.json #110

Closed
jrmartin opened this issue Oct 17, 2019 · 0 comments
Closed
Assignees

Comments

@jrmartin
Copy link
Contributor

jrmartin commented Oct 17, 2019

The Error Modal needs to be configurable by the geppetto-application using it. To do this, the ErrorModal needs to read the values (error messages, links, button visibility) from the GeppettoConfiguration.json. If not added to the GeppettoConfiguration.json, a default set of properties declared in ErrorModal will be used.

ErrorModal properties added to GeppettoConfiguration.json under existing object "properties".

  "properties": {
    "errorDialog": {
      "message" : "I broke geppetto, ops!",
      "githubButton": {
        "enabled" : true,
        "url" : "https://github.com/openworm/org.geppetto/issues/new"
      },
      "twitterButton": {
        "enabled" : true,
        "url" : "https://geppetto.org",
        "message" : "I broke geppetto, ops!"
      }
    }

PR #111 showing the changes needed in ErrorModal.js

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants