[23.05] openwisp-monitoring: align PKG_SOURCE_VERSION with PKG_VERSION #25420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nemesifier
approved these changes
Nov 21, 2024
|
@1715173329 can you help me understand why the CI is failing here? |
pandafy
changed the title
pandafy
changed the title
It caused by recent container breakage, and CI on 23.05 is not updated. |
|
Could you please rebase upon 23.05 HEAD? It should be fixed by 7ee4fe7. |
pandafy
force-pushed
the
openwisp-monitoring-openwrt-23.05-fix
branch
4 times, most recently
from
afdce9a
to
4212dba
Compare
Previously, `PKG_SOURCE_VERSION` in the Makefile was incorrectly set to `0.1.1` instead of tracking `PKG_VERSION`. This mismatch caused compilation issues for the package. This fix ensures `PKG_SOURCE_VERSION` dynamically aligns with `PKG_VERSION` to prevent future discrepancies. Signed-off-by: Gagan Deep <pandafy.dev@gmail.com>
pandafy
force-pushed
the
openwisp-monitoring-openwrt-23.05-fix
branch
from
4212dba
to
8940bef
Compare
|
@1715173329 the CI passes now. |
Merged, thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Maintainer: @nemesifier
Compile tested: ramips
Run tested: ramips
Description:
Previously,
PKG_SOURCE_VERSIONin the Makefile was incorrectly set to0.1.1instead of trackingPKG_VERSION. This mismatch caused compilation issues for the package.This fix ensures
PKG_SOURCE_VERSIONdynamically aligns withPKG_VERSIONto prevent future discrepancies.