Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

OpenX: Analytics Adapter update #39

Closed
wants to merge 1 commit into from
Closed

OpenX: Analytics Adapter update #39

wants to merge 1 commit into from

Conversation

jimee02
Copy link

@jimee02 jimee02 commented Jul 2, 2020 •
edited
Loading

No description provided.

@jimee02 jimee02 requested review from kenan-gillet and hrgui July 2, 2020 00:28
@jimee02 jimee02 force-pushed the analytics-adapter-update branch from ed9e6b6 to b5b5b03 Compare July 2, 2020 16:45
kenan-gillet
kenan-gillet approved these changes Jul 2, 2020
View reviewed changes
Copy link

@kenan-gillet kenan-gillet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, i did not realized that the v1 adapter was already merge upstream

@jimee02
Copy link
Author

jimee02 commented Jul 2, 2020

@kenan-gillet that's not V1, that's Apollo.

@jimee02
Copy link
Author

jimee02 commented Jul 2, 2020

I'm opening a new branch against prebid's main repo with the same branch

@jimee02 jimee02 closed this Jul 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrgui hrgui hrgui approved these changes

@kenan-gillet kenan-gillet kenan-gillet approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jimee02 @kenan-gillet @hrgui