From 92b82de19e3aba87e2ec1fb349049307e2fe7ac7 Mon Sep 17 00:00:00 2001 From: Kevin Gleason Date: Thu, 3 Oct 2024 14:46:08 -0700 Subject: [PATCH] Fix windows only build failure on include filename. Between eliding third_party directory names in includes, and Windows being case insensitive on header include paths, the following include was ambiguous and resolved to (1), leading to issues in using the StableHLO header: ``` #include "stablehlo/transforms/Passes.h" // (1) tensorflow/compiler/mlir/lite/stablehlo/transforms/passes.h // (2) @stablehlo - third_party/stablehlo/stablehlo/transforms/Passes.h ``` PiperOrigin-RevId: 682038464 --- xla/mlir_hlo/BUILD | 1 - xla/mlir_hlo/stablehlo_ext/transforms/passes.h | 6 ------ 2 files changed, 7 deletions(-) diff --git a/xla/mlir_hlo/BUILD b/xla/mlir_hlo/BUILD index e8147577018ee..8b8f59da1a7cb 100644 --- a/xla/mlir_hlo/BUILD +++ b/xla/mlir_hlo/BUILD @@ -1147,7 +1147,6 @@ cc_library( srcs = [ "stablehlo_ext/transforms/chlo_recompose_ops.cpp", "stablehlo_ext/transforms/stablehlo_canonicalize_dynamism.cpp", - "stablehlo_ext/transforms/stablehlo_compatibility_expander.cpp", "stablehlo_ext/transforms/stablehlo_refine_shapes.cpp", ], hdrs = [ diff --git a/xla/mlir_hlo/stablehlo_ext/transforms/passes.h b/xla/mlir_hlo/stablehlo_ext/transforms/passes.h index 22c6d637c1409..e2b77594141f0 100644 --- a/xla/mlir_hlo/stablehlo_ext/transforms/passes.h +++ b/xla/mlir_hlo/stablehlo_ext/transforms/passes.h @@ -32,12 +32,6 @@ namespace stablehlo_ext { void createChloLegalizeToStablehloPipeline(OpPassManager &pm); -// Expand backward compatibility with the given StableHLO version by decomposing -// newer StableHLO operations into equivalent operations supported by that older -// version. -std::unique_ptr createStablehloCompatibilityExpanderPass( - std::string targetVersionOption); - } // namespace stablehlo_ext } // namespace mlir