Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]There is no need to list/watch nodepool in servicetoplogy controller #1553

Closed
rambohe-ch opened this issue Jun 18, 2023 · 0 comments · Fixed by #1554
Closed
Labels
kind/feature kind/feature

Comments

@rambohe-ch
Copy link
Member

What would you like to be added:

  1. As discussed in the issue: [feature request]can not move node to another nodepool by label modification #1382 and pull request feat: prevent node movement by label modification #1444 , node pool name for a node can not be changed after joining into the cluster. if end user wants to change the nodepool name of node, node should be deleted from the cluster and then re-join the node for new nodepool into the cluster.

  2. Because of node deletion and joining, endpoints and endpointslices will be updated explicitly, so there is no need to list/watch nodepool in service topology controller in order to update endpoints and endpointslices when nodepool is changed.

so i want to remove list/watch nodepool action in service topology controller.

Why is this needed:
The efficiency of service topology feature can be improved if nodepool list/watch is removed.
moreover, nodepool list/watch is a dummy function for service topology controller as above description.

others
/kind feature

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature kind/feature
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant