Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] clusterrole yurt-manager-role in yurt-manager helm chart lacks nodes/status resource #1882

Closed
qclc opened this issue Dec 27, 2023 · 2 comments · Fixed by #1884
Closed
Labels
kind/bug kind/bug

Comments

@qclc
Copy link
Member

qclc commented Dec 27, 2023

What happened:
The clusterrole yurt-manager-role in yurt-manager helm chart lacks permissions for nodes/status:
charts/yurt-app-manager/templates/clusterrole.yaml
If role of nodes/status resource is missing, the operation of yurt-manager to update the node status is prohibited.

What you expected to happen:
add nodes/status resources in charts/yurt-app-manager/templates/clusterrole.yaml

- apiGroups:
  - ""
  resources:
  - nodes
  # add this
  - nodes/status
  verbs:
  - get
  - list
  - patch
  - update
  - watch

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
It seems that the helm chart of yurt-manager is automatically generated by openyurt-bot. I haven't found how to add this role in the code yet.

Environment:

  • OpenYurt version:
  • Kubernetes version (use kubectl version):
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

others

/kind bug

@qclc qclc added the kind/bug kind/bug label Dec 27, 2023
@rambohe-ch
Copy link
Member

rambohe-ch commented Dec 28, 2023

@qclc Thank you raising the issue. would you like to make a pull request to fix this bug?

by the way, which controller in yurt-manager need to update node status?

@qclc
Copy link
Member Author

qclc commented Dec 28, 2023

@qclc Thank you raising the issue. would you like to make a pull request to fix this bug?

by the way, which controller in yurt-manager need to update node status?

Ok, the pr has been submitted. This will affect the nodelifecycle-controller of yurt-manager

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants