Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature request]Add commands so that single node could convert to a standard Kubernetes node or an OpenYurt edgenode #190

Closed
Peeknut opened this issue Jan 7, 2021 · 8 comments · Fixed by #206
Assignees

Comments

@Peeknut
Copy link
Member

Peeknut commented Jan 7, 2021

What would you like to be added:
Add commands, such as yurtctl convert edgenode and yurtctl revert edgenode , so that single node could use these commands to convert a standard Kubernetes node to an OpenYurt edgenode or revert an OpenYurt edgenode.

Why is this needed:
The commands yurtctl convertyurtctl revert will convert all edge nodes to OpenYurt cluster or Kubernetes cluster. If a new edge node is added after conversion, there are no corresponding commands to convert it to an OpenYurt edgenode or a Kubernetes node. We can only use commands yurtctl convertyurtctl revert again to convert all edge nodes, which may cause errors and be low efficiency. So commands are needed to allow a single node to convert and revert.

@Peeknut
Copy link
Member Author

Peeknut commented Jan 7, 2021

@rambohe-ch @GsssC

@huangyuqi
Copy link
Member

huangyuqi commented Jan 7, 2021

@Peeknut
Actually, if the node joins the cluster as before, it will still be a stand node ,not a yurt node; Base on the pattern of node joining. We can bring out a command as 'yurtctl convert node xxx' or 'yurtctl revert node xxx' .
BTW, The ability of joining node with yurt type will opensource soon ;

@GsssC
Copy link

GsssC commented Jan 7, 2021

Then we can remove the servant bash script instead of using yurtctl convert edgenode.

@huangyuqi
Copy link
Member

@zyjhtangtang Would you mind bringing a proposal about joining a node in 'yurt' way?

@Peeknut Peeknut changed the title [feature request]Add commands so that single node could convert to a standard Kubernetes cluster or an OpenYurt cluster [feature request]Add commands so that single node could convert to a standard Kubernetes node or an OpenYurt edgenode Jan 7, 2021
@rambohe-ch
Copy link
Member

rambohe-ch commented Jan 7, 2021

@Peeknut
Actually, if the node joins the cluster as before, it will still be a stand node ,not a yurt node; Base on the pattern of node joining. We can bring out a command as 'yurtctl convert node xxx' or 'yurtctl revert node xxx' .
BTW, The ability of joining node with yurt type will opensource soon ;

@huangyuqi i think that node join feature and one node convert feature are different. because when user wants to use a customized tool to join node, node convert feature maybe needed.
so i think node convert feature is welcome. @Peeknut

@rambohe-ch
Copy link
Member

rambohe-ch commented Jan 7, 2021

Then we can remove the servant bash script instead of using yurtctl convert edgenode.

@GsssC yeah, robustness of servant bash script is not so good, it is a good idea to use golang command to refactor it.
@Peeknut would you refactor the node convert/revert feature by golang?

@Peeknut
Copy link
Member Author

Peeknut commented Jan 7, 2021

Then we can remove the servant bash script instead of using yurtctl convert edgenode.

@GsssC yeah, robustness of servant bash script is not so good, it is a good idea to use golang command to refactor it.
@Peeknut would you refactor the node convert/revert feature by golang?

ok

@Walnux
Copy link

Walnux commented Jan 7, 2021

I think this request is reasonable. And we do need a standard way (or feature) for the user to "join the node into the clusters". 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants