Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: upgrade nodepool crd to v1beta2 #2266

Merged
merged 3 commits into from
Jan 22, 2025

Conversation

tnsimon
Copy link
Contributor

@tnsimon tnsimon commented Jan 10, 2025

What type of PR is this?

Uncomment only one /kind <> line, hit enter to put that in a new line, and remove leading whitespace from that line:
/kind feature

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #2258

Special notes for your reviewer:

/assign @rambohe-ch

Does this PR introduce a user-facing change?

Adds updated CRD Nodepool v1beta2 as per https://github.com/openyurtio/openyurt/blob/master/docs/proposals/20241211-reuse-nodepool-list-watch-requests.md#api-changes

other Note

@tnsimon tnsimon requested a review from a team as a code owner January 10, 2025 03:21
@tnsimon tnsimon force-pushed the add-nodepool-v1beta2 branch from 4f8c2ca to 39c82bc Compare January 10, 2025 03:35
Copy link

codecov bot commented Jan 10, 2025

Codecov Report

Attention: Patch coverage is 61.82708% with 234 lines in your changes missing coverage. Please review.

Project coverage is 45.42%. Comparing base (9ba1d5e) to head (263cf9c).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
...r/controller/yurtappset/yurt_app_set_controller.go 57.97% 84 Missing and 3 partials ⚠️
...et/loadbalancerset/load_balancer_set_controller.go 53.33% 35 Missing ⚠️
pkg/apis/apps/v1beta1/nodepool_conversion.go 0.00% 32 Missing ⚠️
...bernetes/kubeadm/app/util/apiclient/idempotency.go 0.00% 31 Missing ⚠️
...er/webhook/nodepool/v1beta2/nodepool_validation.go 69.56% 12 Missing and 2 partials ⚠️
...er/controller/nodebucket/node_bucket_controller.go 72.09% 12 Missing ⚠️
pkg/yurtmanager/webhook/server.go 0.00% 6 Missing ⚠️
pkg/apis/apps/v1alpha1/nodepool_conversion.go 0.00% 5 Missing ⚠️
pkg/apis/apps/v1beta2/default.go 0.00% 3 Missing ⚠️
...manager/controller/nodepool/nodepool_controller.go 25.00% 3 Missing ⚠️
... and 4 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #2266      +/-   ##
==========================================
+ Coverage   45.18%   45.42%   +0.23%     
==========================================
  Files         422      427       +5     
  Lines       28779    29185     +406     
==========================================
+ Hits        13005    13257     +252     
- Misses      14460    14613     +153     
- Partials     1314     1315       +1     
Flag Coverage Δ
unittests 45.42% <61.82%> (+0.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tnsimon tnsimon force-pushed the add-nodepool-v1beta2 branch from a01256d to 5df865a Compare January 15, 2025 00:25
@tnsimon tnsimon force-pushed the add-nodepool-v1beta2 branch 5 times, most recently from f909aa6 to cc6db13 Compare January 22, 2025 09:31
@tnsimon tnsimon force-pushed the add-nodepool-v1beta2 branch from cc6db13 to 263cf9c Compare January 22, 2025 09:48
@tnsimon
Copy link
Contributor Author

tnsimon commented Jan 22, 2025

@rambohe-ch updated all controllers to utilise v1beta2.NodePool scheme.

@rambohe-ch rambohe-ch added approved approved lgtm lgtm labels Jan 22, 2025
@rambohe-ch
Copy link
Member

/LGTM

@rambohe-ch rambohe-ch merged commit 470292f into openyurtio:master Jan 22, 2025
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved approved lgtm lgtm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[feature request]upgrade NodePool CRD to v1beta2
2 participants