Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]How yurtctl convert can better close the nodelifecycle controller (kube-controller-manager)? #391

Closed
Peeknut opened this issue Jul 23, 2021 · 2 comments · Fixed by #399
Labels
kind/bug kind/bug

Comments

@Peeknut
Copy link
Member

Peeknut commented Jul 23, 2021

What happened:
When excuting the command yurtctl convert, the clusterrolebinding system:controller:node-controller will be deleted to turn off the nodelifecycle controller (in kube-controller-manager).
However, the flowing questions will appear afterwards:

What you expected to happen:
yurtctl convert doesn't turn off nodelifecycle controller by deleting clusterrolebinding system:controller:node-controller. And it can support the high availability of kube-controller-manager.

How to reproduce it (as minimally and precisely as possible):

Anything else we need to know?:
Solutions currently proposed:
When executing yurtctl convert, 1) If kube-controller-manager is deployed through static file /etc/kubernetes/manifests/kube-controller-manager.yaml: Create jobs for all candidates to modify this file to turn off nodelifecycle controller . 2) If kube-controller-manager is not deployed through a static file: Modify kube-controller-manager template directly.
And this scheme has the following problems:
If the kube-controller-manager is not deployed through a static file (/etc/kubernetes/manifests/), modify kube-controller-manager template directly will lead to the runtime template is inconsistent with the user's local yaml file.

Environment:

  • OpenYurt version:
  • Kubernetes version (use kubectl version):
  • OS (e.g: cat /etc/os-release):
  • Kernel (e.g. uname -a):
  • Install tools:
  • Others:

others
/kind bug

@Peeknut Peeknut added the kind/bug kind/bug label Jul 23, 2021
@Peeknut
Copy link
Member Author

Peeknut commented Jul 23, 2021

If there are better solutions or suggestions, comments are welcome :)

@rambohe-ch
Copy link
Member

rambohe-ch commented Jul 28, 2021

@Peeknut Thank you filing issue.
We need to add some tutorial document to introduce how to modify kube-controller-manager setting manually by user.
and we can also add the contents of modification to kube-controller-manager that set by yurtctl.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug kind/bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants