Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] DeployYurthubSetting, not delete when revert #489

Closed
adamzhoul opened this issue Sep 22, 2021 · 3 comments · Fixed by #492
Closed

[feature request] DeployYurthubSetting, not delete when revert #489

adamzhoul opened this issue Sep 22, 2021 · 3 comments · Fixed by #492
Assignees
@adamzhoul
Labels
kind/feature kind/feature

Comments

@adamzhoul
Copy link
Member

openyurt/pkg/yurtctl/cmd/convert/convert.go

Line 382 in 797c43d

if err = kubeutil.DeployYurthubSetting(co.clientSet); err != nil {

yurtctl convert : run function DeployYurthubSetting , create yurt-hub ClusterRole ClusterRoleBinding

Howevert, yurtctl revert won't delete them.
@adamzhoul adamzhoul added the kind/feature kind/feature label Sep 22, 2021
@rambohe-ch
Copy link
Member

@adamzhoul I think it's a miss, and welcome you to add DeleteYurthubSetting in yurtctl revert.

@adamzhoul
Copy link
Member Author

ok

@rambohe-ch
Copy link
Member

/assign @adamzhoul

@adamzhoul adamzhoul mentioned this issue Sep 23, 2021
Merged
@adamzhoul adamzhoul mentioned this issue Nov 5, 2021
Merged
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@adamzhoul adamzhoul

Labels
kind/feature kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

add DeleteYurthubSetting to revert adamzhoul/openyurt
2 participants
@adamzhoul @rambohe-ch