Skip to content
This repository has been archived by the owner on Nov 7, 2019. It is now read-only.

Commit

Permalink
8373 TXG_WAIT in ZIL commit path
Browse files Browse the repository at this point in the history
Reviewed by: Prakash Surya <prakash.surya@delphix.com>
Reviewed by: Matthew Ahrens <mahrens@delphix.com>

Closes #428
  • Loading branch information
avg-I authored and Prakash Surya committed Jul 25, 2017
1 parent ed6d032 commit 7f04961
Showing 1 changed file with 18 additions and 1 deletion.
19 changes: 18 additions & 1 deletion usr/src/uts/common/fs/zfs/zil.c
Original file line number Diff line number Diff line change
Expand Up @@ -974,7 +974,24 @@ zil_lwb_write_start(zilog_t *zilog, lwb_t *lwb)
* to clean up in the event of allocation failure or I/O failure.
*/
tx = dmu_tx_create(zilog->zl_os);
VERIFY(dmu_tx_assign(tx, TXG_WAIT) == 0);

/*
* Since we are not going to create any new dirty data and we can even
* help with clearing the existing dirty data, we should not be subject
* to the dirty data based delays.
* We (ab)use TXG_WAITED to bypass the delay mechanism.
* One side effect from using TXG_WAITED is that dmu_tx_assign() can
* fail if the pool is suspended. Those are dramatic circumstances,
* so we return NULL to signal that the normal ZIL processing is not
* possible and txg_wait_synced() should be used to ensure that the data
* is on disk.
*/
error = dmu_tx_assign(tx, TXG_WAITED);
if (error != 0) {
ASSERT3S(error, ==, EIO);
dmu_tx_abort(tx);
return (NULL);
}
dsl_dataset_dirty(dmu_objset_ds(zilog->zl_os), tx);
txg = dmu_tx_get_txg(tx);

Expand Down

0 comments on commit 7f04961

Please sign in to comment.