From 2d5d5dfa8435ff598206693201cd60a09fbb9a8d Mon Sep 17 00:00:00 2001 From: Paul Dagnelie Date: Thu, 29 Aug 2019 11:23:39 -0700 Subject: [PATCH] Matt comment feedback Signed-off-by: Paul Dagnelie --- module/zfs/metaslab.c | 11 ++++++----- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/module/zfs/metaslab.c b/module/zfs/metaslab.c index 12d63431825f..d84541650078 100644 --- a/module/zfs/metaslab.c +++ b/module/zfs/metaslab.c @@ -3553,11 +3553,12 @@ metaslab_sync(metaslab_t *msp, uint64_t txg) * Normally, we don't want to process a metaslab if there are no * allocations or frees to perform. However, if the metaslab is being * forced to condense, it's loaded and we're not beyond the final - * dirty txg, we need to let it through. This prevents an issue where - * metaslabs that need to be condensed but were loaded for other - * reasons could cause a panic here. By only checking the txg in that - * branch of the conditional, we preserve the utility of the VERIFY - * statements in all other cases. + * dirty txg, we need to let it through. Not condensing beyond the + * final dirty txg prevents an issue where metaslabs that need to be + * condensed but were loaded for other reasons could cause a panic + * here. By only checking the txg in that branch of the conditional, + * we preserve the utility of the VERIFY statements in all other + * cases. */ if (range_tree_is_empty(alloctree) && range_tree_is_empty(msp->ms_freeing) &&