Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add notice that forcefully unmount is not supported on Linux. #10013

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

oshogbo
Copy link
Contributor

@oshogbo oshogbo commented Feb 16, 2020

#9700 # Motivation and Context
Add notice that forcefully unmount is not supported on Linux.
As discussed: #9904 (comment)

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@oshogbo oshogbo requested a review from behlendorf February 16, 2020 20:14
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Feb 16, 2020
man/man8/zfs-mount.8 Outdated Show resolved Hide resolved
man/man8/zpool-export.8 Outdated Show resolved Hide resolved
@codecov
Copy link

codecov bot commented Feb 17, 2020

Codecov Report

Merging #10013 into master will increase coverage by <1%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           master   #10013    +/-   ##
========================================
+ Coverage      79%      79%   +<1%     
========================================
  Files         386      386            
  Lines      122431   122431            
========================================
+ Hits        97023    97332   +309     
+ Misses      25408    25099   -309
Flag Coverage Δ
#kernel 80% <ø> (ø) ⬆️
#user 67% <ø> (+1%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ecbbdac...4f6420c. Read the comment docs.

Signed-off-by: Mariusz Zaborski <oshogbo@vexillium.org>
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Feb 18, 2020
@behlendorf behlendorf merged commit 89adffb into openzfs:master Feb 18, 2020
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
The Linux VFS will never allow a filesystem which is in use to
be unmounted.  This behavior differs from other platforms like
FreeBSD which allow a filesystem to be force unmounted.  This 
will result in errors being returned to applications actively
using the filesystem.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Mariusz Zaborski <oshogbo@vexillium.org>
Closes openzfs#10013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants