Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

VN_OPEN_INVFS typo #10322

Merged
merged 1 commit into from
May 15, 2020
Merged

VN_OPEN_INVFS typo #10322

merged 1 commit into from
May 15, 2020

Conversation

yparitcher
Copy link
Contributor

@yparitcher yparitcher commented May 13, 2020 •
edited
Loading

Signed-off-by: yparitcher y@paritcher.com

fix Freebsd typo
VN_OPEN_INVFS literal is in the wrong field

see

zfs/module/os/freebsd/zfs/zfs_vnops.c

Line 6094 in b29e31d

error = vn_open_cred(&nd, &flags, 0600, VN_OPEN_INVFS, ap->a_cred,

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@yparitcher
VN_OPEN_INVFS typo
a56cdaf 
Signed-off-by: yparitcher <y@paritcher.com>
@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label May 13, 2020
@behlendorf
Copy link
Contributor

@mattmacy @amotin would you mind reviewing this.

amotin
amotin approved these changes May 13, 2020
View reviewed changes
Copy link
Member

@amotin amotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense. It came as-is from FreeBSD head, where those do look swapped to me.

@yparitcher
Copy link
Contributor Author

the function signature is:

int	vn_open_cred(struct nameidata *ndp, int *flagp, int cmode,
	    u_int vn_open_flags, struct ucred *cred, struct file *fp);

This should be fixed in FreeBSD also, it just was easier to open a PR here

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels May 14, 2020
@behlendorf behlendorf merged commit cdcce2f into openzfs:master May 15, 2020
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@yparitcher @jsai20
Fix VN_OPEN_INVFS typo
990ddda 
The VN_OPEN_INVFS literal is in the wrong field.

Reviewed-by: Matt Macy <mmacy@FreeBSD.org>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Alexander Motin <mav@FreeBSD.org>
Signed-off-by: yparitcher <y@paritcher.com>
Closes openzfs#10322
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@behlendorf behlendorf behlendorf approved these changes

@mattmacy mattmacy mattmacy approved these changes

@amotin amotin amotin approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@yparitcher @behlendorf @amotin @mattmacy