Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix dead links #10369

Merged
merged 1 commit into from
May 26, 2020
Merged

Fix dead links #10369

merged 1 commit into from
May 26, 2020

Conversation

mschilli87
Copy link
Contributor

@mschilli87 mschilli87 commented May 26, 2020

Replace dead links to http://list.zfsonlinux.org.

Motivation and Context

Fixes #10367.

Description

https://openzfs.github.io/openzfs-docs/Project%20and%20Community/Mailing%20Lists.html would properly be a better direct replacement for http://list.zfsonlinux.org but as there text refers to a specific mailing list, why not use a more specific link as well?

If even a change like this requires me signing off the commit, let me know.
I honestly just used the web interface with auto-fork to do this.
Could do a local clone and force-push a correction.

edit: Heck, I just did it. Writing this excuse above probably took me longer than doing it right.

How Has This Been Tested?

Just changed documentation. So no testing done.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

Copy link
Member

@gmelikov gmelikov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pointing at https://openzfs.github.io/openzfs-docs/Project%20and%20Community/Mailing%20Lists.html looks better for me as a general page about our mailing lists, user will see all mailing lists, not only one of them.

Originally, I wanted to point to directly to
https://zfsonlinux.topicbox.com/groups/zfs-discuss
as the text refers to that specific mailing list, but George Melikov
requested to change it to the general to give users the overview.

Fixes #10367.

Signed-off-by: Marcel Schilling <marcel.schilling@uni-luebeck.de>
@mschilli87
Copy link
Contributor Author

@gmelikov: Done. 🙂

@behlendorf behlendorf added the Status: Accepted Ready to integrate (reviewed, tested) label May 26, 2020
@behlendorf behlendorf merged commit ce98ed2 into openzfs:master May 26, 2020
@mschilli87 mschilli87 deleted the patch-1 branch May 27, 2020 05:47
as-com pushed a commit to as-com/zfs that referenced this pull request Jun 20, 2020
Originally, I wanted to point to directly to
https://zfsonlinux.topicbox.com/groups/zfs-discuss
as the text refers to that specific mailing list, but George Melikov
requested to change it to the general to give users the overview.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Marcel Schilling <marcel.schilling@uni-luebeck.de>
Closes openzfs#10367
Closes openzfs#10369
(cherry picked from commit ce98ed2)
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
Originally, I wanted to point to directly to
https://zfsonlinux.topicbox.com/groups/zfs-discuss
as the text refers to that specific mailing list, but George Melikov
requested to change it to the general to give users the overview.

Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Signed-off-by: Marcel Schilling <marcel.schilling@uni-luebeck.de>
Closes openzfs#10367
Closes openzfs#10369
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Development

Successfully merging this pull request may close these issues.

.github/CONTRIBUTING.md points to invalid list
3 participants