ZTS: Retry export/destroy when busy in zpool_import_012 #10380
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It can take a moment for the NFS server to give up the mountpoint after unsharing a filesystem. Use log_must_busy to retry export/destroy a few times after switching off sharenfs. Signed-off-by: Ryan Moeller <ryan@iXsystems.com>
ghost
added
Component: Test Suite
ghost
requested a review
from 
behlendorf
approved these changes
May 27, 2020
ikozhukhov
approved these changes
May 27, 2020
gmelikov
approved these changes
May 27, 2020
behlendorf
added
Status: Accepted
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
It can take a moment for the NFS server to give up the mountpoint after unsharing a filesystem. Use log_must_busy to retry export/destroy a few times after switching off sharenfs. Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: George Melikov <mail@gmelikov.ru> Signed-off-by: Ryan Moeller <ryan@iXsystems.com> Closes openzfs#10380
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
It can take a moment for the NFS server to give up the mountpoint
after unsharing a filesystem.
Description
Use log_must_busy to retry export/destroy a few times after switching
off sharenfs.
How Has This Been Tested?
Ran 1000 iterations of the test with no error. Actually there was an unrelated error. I may have found a bug in the test runner, because I found my user exceeded kern.maxfiles somehow after a great number of iterations. But the test did not fail up until the point the test runner failed :)
Types of changes
Checklist:
Signed-off-by.