Upstream: Replace sprintf()->snprintf() strcpy()->strlcpy() #10400
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kithrup
reviewed
Jun 4, 2020
kithrup
reviewed
Jun 4, 2020
kithrup
reviewed
Jun 4, 2020
kithrup
approved these changes
Jun 4, 2020
|
Threw some of the repeated math into a local variable, hopefully that is a little more readable. |
|
Corrected the #ifdefs around the _set_impl functions. But could get rid of them entirely if there is a solution for the |
Codecov Report
@@ Coverage Diff @@
## master #10400 +/- ##
==========================================
- Coverage 79.56% 79.36% -0.20%
==========================================
Files 391 391
Lines 123624 123628 +4
==========================================
- Hits 98357 98123 -234
- Misses 25267 25505 +238
Continue to review full report at Codecov.
|
behlendorf
reviewed
Jun 4, 2020
lundman
force-pushed
the
macOS_pr3
branch
2 times, most recently
from
4434ec2 to
a19fd0f
Compare
|
Look's like some cstyle warnings. Aside from that, this looks good to me. We had a CI glitch so I went and resubmitted the unexpected failed builds to see if there were real issues. |
If other platforms miss snprintf, we should add a #define to sprintf, likewise strlcpy(). Biggest change is adding another size parameter to zfs_id_to_fuidstr(). The various *_impl_get() functions have been taken out for macOS, using I am unsure of its size. If someone with Linux background knows the size, I can update the PR. (It will not even compile using strcpy). Signed-off-by: Jorgen Lundman <lundman@lundman.net>
|
cstyle corrected, also, it seems |
behlendorf
approved these changes
Jun 7, 2020
behlendorf
added
Status: Accepted
BrainSlayer
pushed a commit
to BrainSlayer/zfs
that referenced
this pull request
Jun 10, 2020
The strcpy() and sprintf() functions are deprecated on some platforms. Care is needed to ensure correct size is used. If some platforms miss snprintf, we can add a #define to sprintf, likewise strlcpy(). The biggest change is adding a size parameter to zfs_id_to_fuidstr(). The various *_impl_get() functions are only used on linux and have not yet been updated. Reviewed by: Sean Eric Fagan <sef@ixsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes openzfs#10400
lundman
referenced
this pull request
in openzfsonosx/openzfs
Jun 12, 2020
The strcpy() and sprintf() functions are deprecated on some platforms. Care is needed to ensure correct size is used. If some platforms miss snprintf, we can add a #define to sprintf, likewise strlcpy(). The biggest change is adding a size parameter to zfs_id_to_fuidstr(). The various *_impl_get() functions are only used on linux and have not yet been updated. Reviewed by: Sean Eric Fagan <sef@ixsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes #10400
as-com
pushed a commit
to as-com/zfs
that referenced
this pull request
Jun 20, 2020
The strcpy() and sprintf() functions are deprecated on some platforms. Care is needed to ensure correct size is used. If some platforms miss snprintf, we can add a #define to sprintf, likewise strlcpy(). The biggest change is adding a size parameter to zfs_id_to_fuidstr(). The various *_impl_get() functions are only used on linux and have not yet been updated. Reviewed by: Sean Eric Fagan <sef@ixsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes openzfs#10400 (cherry picked from commit c9e319f)
13 tasks
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
The strcpy() and sprintf() functions are deprecated on some platforms. Care is needed to ensure correct size is used. If some platforms miss snprintf, we can add a #define to sprintf, likewise strlcpy(). The biggest change is adding a size parameter to zfs_id_to_fuidstr(). The various *_impl_get() functions are only used on linux and have not yet been updated. Reviewed by: Sean Eric Fagan <sef@ixsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes openzfs#10400
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
The strcpy() and sprintf() functions are deprecated on some platforms. Care is needed to ensure correct size is used. If some platforms miss snprintf, we can add a #define to sprintf, likewise strlcpy(). The biggest change is adding a size parameter to zfs_id_to_fuidstr(). The various *_impl_get() functions are only used on linux and have not yet been updated. Reviewed by: Sean Eric Fagan <sef@ixsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Jorgen Lundman <lundman@lundman.net> Closes openzfs#10400
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
strcpy() and sprintf() are deprecated on some platforms.
Care is needed to ensure correct size is used.
Motivation and Context
Unfortunately, compiling stops with error when attempting to use deprecated
functions on macOS.
Description
If other platforms miss snprintf, we should add a #define to
sprintf, likewise strlcpy().
Biggest change is adding another size parameter to zfs_id_to_fuidstr().
The various *_impl_get() functions have been taken out for macOS, using
#ifdefs as the string is passed to ZFS from the Linux kernel. I am unsure of its size. If someone with Linux background knows the size, I can update the PR. (It will not even compile using strcpy).
Did git just eat part of the commit message? Oh heh, '#' is comment.
How Has This Been Tested?
Extensive testing of zfs-test on macOS. Other platforms unknown.
Types of changes
Checklist:
Signed-off-by.