Restore support for in-kernel ZFS ioctls. #10417
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In Illumos it is possible to call ioctl functions from within the kernel by passing the FKIOCTL flag. Neither FreeBSD nor Linux support that, but it doesn't hurt to keep it around, as all the code is there. Before this commit it was a dead code and zc_iflags was always zero. Restore this functionality by allowing to pass a flag to the zfsdev_ioctl_common() function. Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net>
Codecov Report
@@ Coverage Diff @@
## master #10417 +/- ##
==========================================
- Coverage 79.61% 79.54% -0.07%
==========================================
Files 391 391
Lines 123603 123603
==========================================
- Hits 98402 98318 -84
- Misses 25201 25285 +84
Continue to review full report at Codecov.
|
ghost
approved these changes
Jun 8, 2020
ghost
added
the
behlendorf
approved these changes
Jun 8, 2020
behlendorf
added
Status: Accepted
BrainSlayer
pushed a commit
to BrainSlayer/zfs
that referenced
this pull request
Jun 10, 2020
In Illumos it is possible to call ioctl functions from within the kernel by passing the FKIOCTL flag. Neither FreeBSD nor Linux support that, but it doesn't hurt to keep it around, as all the code is there. Before this commit it was a dead code and zc_iflags was always zero. Restore this functionality by allowing to pass a flag to the zfsdev_ioctl_common() function. Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net> Closes openzfs#10417
lundman
referenced
this pull request
in openzfsonosx/openzfs
Jun 12, 2020
In Illumos it is possible to call ioctl functions from within the kernel by passing the FKIOCTL flag. Neither FreeBSD nor Linux support that, but it doesn't hurt to keep it around, as all the code is there. Before this commit it was a dead code and zc_iflags was always zero. Restore this functionality by allowing to pass a flag to the zfsdev_ioctl_common() function. Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net> Closes #10417
jsai20
pushed a commit
to jsai20/zfs
that referenced
this pull request
Mar 30, 2021
In Illumos it is possible to call ioctl functions from within the kernel by passing the FKIOCTL flag. Neither FreeBSD nor Linux support that, but it doesn't hurt to keep it around, as all the code is there. Before this commit it was a dead code and zc_iflags was always zero. Restore this functionality by allowing to pass a flag to the zfsdev_ioctl_common() function. Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net> Closes openzfs#10417
sempervictus
pushed a commit
to sempervictus/zfs
that referenced
this pull request
May 31, 2021
In Illumos it is possible to call ioctl functions from within the kernel by passing the FKIOCTL flag. Neither FreeBSD nor Linux support that, but it doesn't hurt to keep it around, as all the code is there. Before this commit it was a dead code and zc_iflags was always zero. Restore this functionality by allowing to pass a flag to the zfsdev_ioctl_common() function. Reviewed-by: Ryan Moeller <ryan@iXsystems.com> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Signed-off-by: Pawel Jakub Dawidek <pawel@dawidek.net> Closes openzfs#10417
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
During code reading of ZFS ioctl handling I found some dead code: the zc_iflags field in the zfs_cmd structure is always 0 due to:
int flag = 0;
[...]
zc->zc_iflags = flag & FKIOCTL;
In Illumos it is possible to call ioctl functions from within the kernel by passing the FKIOCTL flag. Neither FreeBSD nor Linux support that, but it doesn't hurt to keep it around, as all the code is there.
Description
Restore this functionality by allowing to pass a flag to the zfsdev_ioctl_common() function.
If we decide to entirely drop support for Illumos, we could remove the flag argument from zfsdev_ioctl_common(), remove zc_iflags field from the zfs_cmd structure, remove the iflag argument from the get_nvlist() function and remove the flags argument from the ddi_copyout() function.
How Has This Been Tested?
The code was compiled on FreeBSD, module was loaded and few operations were performed to test that ioctls to /dev/zfs still work.
Types of changes
Checklist:
Signed-off-by.