Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix add-o_ashift.ksh #10426

Merged
merged 1 commit into from
Jun 9, 2020
Merged

fix add-o_ashift.ksh #10426

merged 1 commit into from
Jun 9, 2020

Conversation

ikozhukhov
Copy link
Contributor

use option '-o' after action for compatibility

Signed-off-by: Igor Kozhukhov igor@dilos.org

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

  • My code follows the ZFS on Linux code style requirements.
  • I have updated the documentation accordingly.
  • I have read the contributing document.
  • I have added tests to cover my changes.
  • I have run the ZFS Test Suite with this change applied.
  • All commit messages are properly formatted and contain Signed-off-by.

@ikozhukhov
fix add-o_ashift.ksh
b37a231 
Signed-off-by: Igor Kozhukhov <igor@dilos.org>
@ghost ghost added Status: Code Review Needed Ready for review and testing Component: Test Suite Indicates an issue with the test framework or a test case labels Jun 9, 2020
@codecov
Copy link

codecov bot commented Jun 9, 2020 •
edited
Loading

Codecov Report

Merging #10426 into master will decrease coverage by 0.09%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #10426      +/-   ##
==========================================
- Coverage   79.56%   79.47%   -0.10%     
==========================================
  Files         391      391              
  Lines      123629   123629              
==========================================
- Hits        98369    98248     -121     
- Misses      25260    25381     +121
Flag Coverage Δ
#kernel 79.94% <ø> (-0.14%) ⬇️
#user 66.02% <ø> (-0.29%) ⬇️
Impacted Files Coverage Δ
module/os/linux/spl/spl-zlib.c 55.35% <0.00%> (-28.58%) ⬇️
module/zfs/aggsum.c 95.34% <0.00%> (-4.66%) ⬇️
cmd/ztest/ztest.c 78.72% <0.00%> (-3.62%) ⬇️
module/os/linux/zfs/arc_os.c 59.67% <0.00%> (-3.23%) ⬇️
module/icp/algs/modes/gcm.c 78.91% <0.00%> (-2.90%) ⬇️
module/zfs/zio_compress.c 89.74% <0.00%> (-2.57%) ⬇️
module/icp/api/kcf_mac.c 37.14% <0.00%> (-2.29%) ⬇️
lib/libzpool/kernel.c 64.09% <0.00%> (-2.28%) ⬇️
module/os/linux/zfs/vdev_file.c 80.37% <0.00%> (-1.87%) ⬇️
module/zfs/zil.c 91.33% <0.00%> (-1.87%) ⬇️
... and 59 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6026507...b37a231. Read the comment docs.

@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Jun 9, 2020
@behlendorf behlendorf merged commit 6722be2 into openzfs:master Jun 9, 2020
BrainSlayer pushed a commit to BrainSlayer/zfs that referenced this pull request Jun 10, 2020
@ikozhukhov @BrainSlayer
ZTS: Fix add-o_ashift.ksh
284c88a 
Use option '-o' after action for compatibility

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Igor Kozhukhov <igor@dilos.org>
Closes openzfs#10426
lundman referenced this pull request in openzfsonosx/openzfs Jun 12, 2020
@ikozhukhov @lundman
ZTS: Fix add-o_ashift.ksh
aeea651 
Use option '-o' after action for compatibility

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Igor Kozhukhov <igor@dilos.org>
Closes #10426
jsai20 pushed a commit to jsai20/zfs that referenced this pull request Mar 30, 2021
@ikozhukhov @jsai20
ZTS: Fix add-o_ashift.ksh
818e764 
Use option '-o' after action for compatibility

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Igor Kozhukhov <igor@dilos.org>
Closes openzfs#10426
sempervictus pushed a commit to sempervictus/zfs that referenced this pull request May 31, 2021
@ikozhukhov
ZTS: Fix add-o_ashift.ksh
03c3f89 
Use option '-o' after action for compatibility

Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Reviewed-by: Ryan Moeller <ryan@iXsystems.com>
Signed-off-by: Igor Kozhukhov <igor@dilos.org>
Closes openzfs#10426
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Component: Test Suite Indicates an issue with the test framework or a test case Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ikozhukhov @behlendorf @gmelikov