FreeBSD: Fix UNIX permissions checking

[mattmacy]

Signed-off-by: Matt Macy mmacy@FreeBSD.org

Motivation and Context

Description

How Has This Been Tested?

Types of changes

• Bug fix (non-breaking change which fixes an issue)
• New feature (non-breaking change which adds functionality)
• Performance enhancement (non-breaking change which improves efficiency)
• Code cleanup (non-breaking change which makes code smaller or more readable)
• Breaking change (fix or feature that would cause existing functionality to change)
• Documentation (a change to man pages or other documentation)

Checklist:

• My code follows the ZFS on Linux code style requirements.
• I have updated the documentation accordingly.
• I have read the contributing document.
• I have added tests to cover my changes.
• I have run the ZFS Test Suite with this change applied.
• All commit messages are properly formatted and contain Signed-off-by.

[ghost]

Passes our internal API tests for NFSv4 ACLs now. I'm in the process of converting those tests to something usable in ZTS.

[codecov]

Codecov Report

Merging #10727 into master will decrease coverage by 0.08%.
The diff coverage is 80.00%.

@@            Coverage Diff             @@
##           master   #10727      +/-   ##
==========================================
- Coverage   79.72%   79.63%   -0.09%     
==========================================
  Files         394      394              
  Lines      124665   124666       +1     
==========================================
- Hits        99390    99279     -111     
- Misses      25275    25387     +112     

Flag	Coverage Δ
#kernel	80.34% <100.00%> (-0.05%)	⬇️
#user	65.10% <0.00%> (-0.70%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files	Coverage Δ
module/zfs/arc.c	89.52% <66.66%> (+<0.01%)	⬆️
module/zfs/zfs_fuid.c	14.85% <100.00%> (ø)
module/os/linux/spl/spl-zlib.c	55.35% <0.00%> (-28.58%)	⬇️
cmd/zvol_id/zvol_id_main.c	76.31% <0.00%> (-5.27%)	⬇️
module/zfs/vdev_removal.c	94.40% <0.00%> (-3.20%)	⬇️
module/zfs/vdev_rebuild.c	93.69% <0.00%> (-2.83%)	⬇️
module/icp/api/kcf_mac.c	37.14% <0.00%> (-1.72%)	⬇️
module/zfs/vdev_indirect_mapping.c	97.10% <0.00%> (-1.45%)	⬇️
module/zfs/zap_micro.c	85.35% <0.00%> (-1.26%)	⬇️
module/zfs/spa_log_spacemap.c	91.97% <0.00%> (-1.15%)	⬇️
... and 46 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9352d8c...c2a93c3. Read the comment docs.