ZTS: Clean up zfs_clone_010_pos #9284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
ikozhukhov
reviewed
Sep 4, 2019
tests/zfs-tests/tests/functional/cli_root/zfs_clone/zfs_clone_010_pos.ksh
Outdated
Show resolved
Hide resolved
ikozhukhov
reviewed
Sep 4, 2019
tests/zfs-tests/tests/functional/cli_root/zfs_clone/zfs_clone_010_pos.ksh
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## master #9284 +/- ##
==========================================
+ Coverage 79.06% 79.13% +0.06%
==========================================
Files 400 400
Lines 122041 122041
==========================================
+ Hits 96494 96578 +84
+ Misses 25547 25463 -84
Continue to review full report at Codecov.
|
Remove a lot of unnecessary setting and incrementing of `i`. Remove unused variable `j`. Instead of calling out to Python in a loop to generate the same string repeatedly, call it once outside of the loop. And add parenthesis to make the print statement compatible with Python 3. Signed-off-by: Ryan Moeller <ryan@ixsystems.com>
ghost
force-pushed
the
zfs_clone_010-cleanup
branch
from
378236c to
1e90971
Compare
|
I would like to amend the commit message to reflect the removal of Python after the tests have run. Should I use |
behlendorf
approved these changes
Sep 5, 2019
|
@freqlabs it's OK to let the tests run again. The additional testing is always welcome. However, if you prefer you could simply post the updated commit message as a commit and I can fix up the comment when merging this. |
|
@behlendorf thanks, to give the buildbots a chance to test someone else's work here is my updated commit message: |
behlendorf
added
Status: Accepted
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 24, 2019
Remove a lot of unnecessary setting and incrementing of `i`. Remove unused variable `j`. Instead of calling out to Python in a loop to generate the same string repeatedly, generate the string once using shell constructs before entering the loop. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Signed-off-by: Ryan Moeller <ryan@ixsystems.com> Closes openzfs#9284
tonyhutter
pushed a commit
to tonyhutter/zfs
that referenced
this pull request
Dec 27, 2019
Remove a lot of unnecessary setting and incrementing of `i`. Remove unused variable `j`. Instead of calling out to Python in a loop to generate the same string repeatedly, generate the string once using shell constructs before entering the loop. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Signed-off-by: Ryan Moeller <ryan@ixsystems.com> Closes openzfs#9284
tonyhutter
pushed a commit
that referenced
this pull request
Jan 23, 2020
Remove a lot of unnecessary setting and incrementing of `i`. Remove unused variable `j`. Instead of calling out to Python in a loop to generate the same string repeatedly, generate the string once using shell constructs before entering the loop. Reviewed-by: Igor Kozhukhov <igor@dilos.org> Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov> Reviewed-by: Richard Elling <Richard.Elling@RichardElling.com> Signed-off-by: Ryan Moeller <ryan@ixsystems.com> Closes #9284
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
On many systems,
pythonis Python 3. zfs_clone_010_pos invokespython -c 'print "x" * 200', which is not valid in Python 3.Description
Eliminate the Python, using built in shell constructs in its place.
While here, a few more potential improvements revealed themselves:
Remove a lot of unnecessary setting and incrementing of
i.Remove unused variable
j.Instead of generating the same string repeatedly inside a loop, generate it once outside of the loop.
How Has This Been Tested?
./scripts/zfs-tests.sh -vxT zfs_cloneTypes of changes
Checklist:
Signed-off-by.