Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use correct format string when printing int8 #9486

Merged
merged 1 commit into from
Oct 21, 2019
Merged

Use correct format string when printing int8 #9486

merged 1 commit into from
Oct 21, 2019

Conversation

mattmacy
Copy link
Contributor

Signed-off-by: Matt Macy mmacy@FreeBSD.org

Motivation and Context

Description

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Performance enhancement (non-breaking change which improves efficiency)
  • Code cleanup (non-breaking change which makes code smaller or more readable)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation (a change to man pages or other documentation)

Checklist:

@mattmacy
Use correct format string when printing int8
2048a46 
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
@codecov
Copy link

codecov bot commented Oct 19, 2019 •
edited
Loading

Codecov Report

Merging #9486 into master will increase coverage by 0.23%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #9486      +/-   ##
==========================================
+ Coverage   78.98%   79.22%   +0.23%     
==========================================
  Files         416      416              
  Lines      123655   123655              
==========================================
+ Hits        97674    97962     +288     
+ Misses      25981    25693     -288
Flag Coverage Δ
#kernel 79.73% <ø> (+0.02%) ⬆️
#user 67.29% <0%> (+0.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4063440...2048a46. Read the comment docs.

behlendorf
behlendorf approved these changes Oct 20, 2019
View reviewed changes
Copy link
Contributor

@behlendorf behlendorf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch.

@behlendorf behlendorf added the Status: Code Review Needed Ready for review and testing label Oct 20, 2019
@behlendorf behlendorf added Status: Accepted Ready to integrate (reviewed, tested) and removed Status: Code Review Needed Ready for review and testing labels Oct 21, 2019
@behlendorf behlendorf merged commit 685abd5 into openzfs:master Oct 21, 2019
@mattmacy mattmacy deleted the projects/libnvpair_fix branch December 19, 2019 22:28
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 26, 2019
@mattmacy @tonyhutter
Use correct format string when printing int8
9847dce 
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#9486
tonyhutter pushed a commit to tonyhutter/zfs that referenced this pull request Dec 27, 2019
@mattmacy @tonyhutter
Use correct format string when printing int8
d8cd6a8 
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes openzfs#9486
tonyhutter pushed a commit that referenced this pull request Jan 23, 2020
@mattmacy @tonyhutter
Use correct format string when printing int8
09015c2 
Reviewed-by: Igor Kozhukhov <igor@dilos.org>
Reviewed-by: Ryan Moeller <ryan@ixsystems.com>
Reviewed-by: George Melikov <mail@gmelikov.ru>
Reviewed-by: Brian Behlendorf <behlendorf1@llnl.gov>
Signed-off-by: Matt Macy <mmacy@FreeBSD.org>
Closes #9486
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gmelikov gmelikov gmelikov approved these changes

@ikozhukhov ikozhukhov ikozhukhov approved these changes

@behlendorf behlendorf behlendorf approved these changes

Assignees
No one assigned
Labels
Status: Accepted Ready to integrate (reviewed, tested)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mattmacy @behlendorf @ikozhukhov @gmelikov